SimStore: Support for OpenMM snapshots - #949
Conversation
Ran tests and reloaded old files, so this shouldn't break things
|
@dwhswenson I don't have any old netcdf available that I would like to load up (all of them used to take a long time to even open up). |
|
@sroet : The main thing I want to check is that any existing analysis (especially anything that requires snapshot coord/vels, like calculating a new CV on existing data or even simulation restarts) still works. So if you have any scripts along those lines that will work on a small dataset, then please do! (Obviously, some analyses, like TIS, only work with a lot of data.) I've checked a few basic analysis scripts that I have, and it seemed to work. In principle, everything should work -- older files will just create snapshots with, e.g., |
np.array with no shape should return float
|
This is ready for review and comment. I will leave it open for at least 48 hours, merging no earlier than Tue 22 Dec 07:00 GMT (08:00 local). |
The
This seems to me that at least continuing simulations (into new storgaes) is possible and is as far as I have time/hardware to spend on this. |
|
Thanks @sroet : If this can load a trajectory that's that old, including recalculating things (as would be needed from |
This will make it possible to store OpenMM snapshots in SimStore.
Note: this changes OpenMM snapshots so that the
KineticContainerandStaticContainerobjects, which are wrappers around the velocities and coordinates/box vectors, respectively, now also carry information about the engine of their associated snapshot. This should be fully backward compatible with the old storage. I've done some minor testing of that, but it would be nice if someone with older files (maybe @sroet, @arjunwadhawan, or @hejung?) could double-check that they can open/analyze older netcdfplus files when they check out this branch.This also involves significant refactoring under the hood of SimStore, making it more flexible with regards to adding user-defined types.
I'm going to add some unit tests and docstrings before declaring it ready for review, but it's already at a point where I'm hoping to get some help with checking backward compatibility.