Skip to content

SimStore: Simplify OPS Storage constructor - #950

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:simstore-simplify
Dec 23, 2020
Merged

SimStore: Simplify OPS Storage constructor#950
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:simstore-simplify

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Finally settling internally on the API: You can now set up an OPS storage with:

storage = Storage(filename, mode)

No more of this from_backend stuff!

@sroet

sroet commented Dec 21, 2020

Copy link
Copy Markdown
Member

No more of this from_backend stuff!

🎉

This LGTM, (assuming all checks are green)

@dwhswenson

Copy link
Copy Markdown
Member Author

Even with @sroet's review, I will leave this open for at least 24 hours, merging no earlier than Tue 22 Dec 16:00 GMT (17:00 local). 😉

@dwhswenson
dwhswenson merged commit 3c9ef75 into openpathsampling:master Dec 23, 2020
@dwhswenson
dwhswenson deleted the simstore-simplify branch December 23, 2020 03:39
@dwhswenson dwhswenson mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants