Skip to content

Fix broken link in Readme.md of toy mstis examples - #963

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
sroet:patch-1
Jan 22, 2021
Merged

Fix broken link in Readme.md of toy mstis examples#963
dwhswenson merged 2 commits into
openpathsampling:masterfrom
sroet:patch-1

Conversation

@sroet

@sroet sroet commented Jan 21, 2021

Copy link
Copy Markdown
Member

When looking through the repository, I noticed that the link 404ed

@sroet
Update Readme.md of toy mstis examples
2db1ac7 
When looking through the repository, I noticed that the link `404`ed
@codecov

codecov Bot commented Jan 21, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #963 (000d526) into master (5f9c545) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files         136      136           
  Lines       14449    14449           
=======================================
  Hits        11596    11596           
  Misses       2853     2853

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9c545...000d526. Read the comment docs.

@sroet sroet mentioned this pull request Jan 22, 2021
Merged
dwhswenson
dwhswenson approved these changes Jan 22, 2021
View reviewed changes

@dwhswenson dwhswenson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that I managed to not fill in that URL! Thanks for the fix. Currently re-running tests (the coverage drop should have been fixed by #964); will merge after tests run.

@dwhswenson dwhswenson changed the title Update Readme.md of toy mstis examples Fix broken link in Readme.md of toy mstis examples Jan 22, 2021
@sroet

sroet commented Jan 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Currently re-running tests (the coverage drop should have been fixed by #964); will merge after tests run.

I don't think that actually runs on current master (as it is still my (un-updated) branch), will merge master to trigger another run

@dwhswenson

dwhswenson commented Jan 22, 2021

Copy link
Copy Markdown
Member

I don't think that actually runs on current master (as it is still my (un-updated) branch), will merge master to trigger another run

CI tests on a merge commit. I'm not sure if the previous merge commit is cached for GitHub Actions. But even if so, good chance you wouldn't get the same coverage drop ;-)

@dwhswenson
dwhswenson merged commit 5ea30ac into openpathsampling:master Jan 22, 2021
@sroet
sroet deleted the patch-1 branch January 22, 2021 15:19
@dwhswenson dwhswenson mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwhswenson dwhswenson dwhswenson approved these changes

Assignees

No one assigned

Labels

misc PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sroet @dwhswenson