Remove some Py2-specific code - #981
Conversation
|
Looking at the code, shouldn't that always (assuming 225 if type(my_options[variable]) is type(default_value):
251 else:
okay_options[variable] = my_options[variable]What input type do you expect to be a subclass of |
Codecov Report
@@ Coverage Diff @@
## dev-2.0 #981 +/- ##
========================================
Coverage 80.25% 80.26%
========================================
Files 136 136
Lines 14449 14455 +6
========================================
+ Hits 11596 11602 +6
Misses 2853 2853
Continue to review full report at Codecov.
|
Yeah, that's it. Py 2.7 had I removed that line and all references to |
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Tue 23 Feb 14:00 GMT (15:00 local). |
#977 dropped Python 2 from the OPS 2.0 test matrix. In the process, some code lost coverage. Here I remove the Py2-specific code for most of that (except netcdfplus, which I'm not worrying about since it will also be dropped in 2.0).
There's one line where I don't immediately understand how it lost coverage:
openpathsampling/openpathsampling/engines/dynamics_engine.py
Line 256 in 6ff2cbb
This is in an instance test against
basestring, butbasestringisstrfor Py3+ (we set it at the top of the file). Any idea why that's not getting covered? (particularly @sroet)Note that this PR is not intended to drop all Py2-related code -- there's more to do on that. This is just catching the things that lost coverage when Py2 left the test matrix.