Update CI build and Readme#6
Open
illusionyy wants to merge 2 commits into
Open
Conversation
746c69d to
250aab8
Compare
- Add instruction on how to setup without building - Add instruction on how to install dotnet (ubuntu) - Update CI to make release using `gh`
fjtrujy
reviewed
Nov 7, 2022
| export ORBISDEV=$PWD/orbisdev | ||
| export PATH=$ORBISDEV/bin:$PATH | ||
| ./build-all.sh | ||
| - name: Build stage 1 |
Contributor
There was a problem hiding this comment.
why are you running here in separate stages?
Author
There was a problem hiding this comment.
The time to run the individual stages can be monitored and if anything fails, it's easier to fix them instead of going through thousands line of log if running them all at once.
Contributor
There was a problem hiding this comment.
Nah.... when it fails it will show at the very end of the log what stage failed anyway.
fjtrujy
reviewed
Nov 7, 2022
| paths-ignore: | ||
| - '*.md' | ||
| pull_request: | ||
| paths-ignore: |
Contributor
There was a problem hiding this comment.
Sometimes we do dummy changes in the Readme to trigger a new CI execution, either you add a way of manually launching them, or remove that lines
Author
There was a problem hiding this comment.
Added workflow_dispatch if you want to trigger a workflow manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghSample build https://github.com/illusion0001/orbisdev/releases/tag/1.037
Readme: https://github.com/illusion0001/orbisdev/tree/patch-1#readme