Raise CaptionReadSyntaxError for malformed SRT instead of IndexError/ValueError - #417
Open
eeshsaxena wants to merge 1 commit into
Open
Raise CaptionReadSyntaxError for malformed SRT instead of IndexError/ValueError#417eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
…ValueError SRTReader.detect read lines[1] without checking there were two lines, and SRTReader.read parsed the '-->' timing line and each timestamp without validating them. Single-line content, a timing line missing its end timestamp, or a non-numeric timestamp raised a bare IndexError or ValueError. detect now returns False for short content and read raises CaptionReadSyntaxError for a malformed timing line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SRT reader raises bare
IndexError/ValueErroron some malformed input instead of aCaptionRead*error:SRTReader().detect("1")->IndexError(readslines[1]without checking there are two lines)SRTReader().read("1\n00:00:01,000 -->\nHi")->IndexErrorfrom an empty end timestampValueErrorI made
detectreturnFalsefor content with fewer than two lines, andreadvalidate the-->timing line and wrap timestamp parsing so a malformed timing line raisesCaptionReadSyntaxError. Valid SRT parsing is unchanged.Added tests for single-line detection and malformed timing; they fail on
mainwith IndexError/ValueError and pass with the change, and the rest of the SRT tests still pass. Found it by fuzzing the readers with mutated captions.