Skip to content

Moving predis to suggest#48

Merged
cryptiklemur merged 2 commits into
masterfrom
aequasi-patch-1
Apr 22, 2016
Merged

Moving predis to suggest#48
cryptiklemur merged 2 commits into
masterfrom
aequasi-patch-1

Conversation

@cryptiklemur

Copy link
Copy Markdown
Member

Resolves #47

@codecov-io

Copy link
Copy Markdown

Current coverage is 90.61%

Merging #48 into master will decrease coverage by -0.37% as of d7c89d2

@@            master     #48   diff @@
======================================
  Files           21      21       
  Stmts          765     799    +34
  Branches         0       0       
  Methods        189     192     +3
======================================
+ Hit            696     724    +28
  Partial          0       0       
- Missed          69      75     +6

Review entire Coverage Diff as of d7c89d2

Powered by Codecov. Updated on successful CI builds.

@cryptiklemur cryptiklemur merged commit d138d3f into master Apr 22, 2016
@cryptiklemur cryptiklemur deleted the aequasi-patch-1 branch April 22, 2016 16:35
@Nyholm

Nyholm commented Apr 23, 2016

Copy link
Copy Markdown
Member

Why not move it to require-dev? It would be great if I could do composer update and then run all the tests. Predis has no requirement on PHP extensions like monogdb has.

@cryptiklemur

Copy link
Copy Markdown
Member Author

True, I can change it to that. Its still running all the tests fine though

@Nyholm

Nyholm commented Apr 23, 2016

Copy link
Copy Markdown
Member

Please do. It works fine on Travis but not on my local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants