Skip to content

Support Expressive 3#20

Merged
snapshotpl merged 11 commits into
php-middleware:masterfrom
prolic:expressive3
Apr 11, 2018
Merged

Support Expressive 3#20
snapshotpl merged 11 commits into
php-middleware:masterfrom
prolic:expressive3

Conversation

@prolic

@prolic prolic commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@prolic

prolic commented Mar 26, 2018

Copy link
Copy Markdown
Contributor Author

Sorry, tests fail at the moment. You can take it either over from here or give me some hints on how to fix the tests.

@snapshotpl snapshotpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution I will take a look at falling tests

Comment thread composer.json Outdated
"php": "^7.1",
"psr/http-server-handler": "^1.0",
"psr/http-server-middleware": "^1.0",
"maximebf/debugbar": "^1.15",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we need to update this dependecy?

@snapshotpl snapshotpl merged commit 6c06189 into php-middleware:master Apr 11, 2018
@snapshotpl

Copy link
Copy Markdown
Member

Thx @prolic !

@prolic prolic deleted the expressive3 branch April 12, 2018 10:44
@prolic

prolic commented Apr 12, 2018

Copy link
Copy Markdown
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants