Skip to content

Skip any tests that required rust to be installed when it isn't available #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alsutton wants to merge 4 commits into from
+20 −1
Closed

Skip any tests that required rust to be installed when it isn't available #3688

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6ed5d4
Skip any tests that required rust to be installed when it isn't avail…
alsutton May 15, 2026
8c70472
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 15, 2026
dfe120b
Move assert to a skipIf to ensure it's skipped on platforms where it …
alsutton May 15, 2026
91cbcb5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion tests/languages/rust_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,39 @@
ACTUAL_GET_DEFAULT_VERSION = rust.get_default_version.__wrapped__


def requires_locally_installed_cargo():
return pytest.mark.skipif(
parse_shebang.find_executable('cargo') is None,
reason='Cargo is not installed in the local environment',
)


def requires_locally_installed_rustup():
return pytest.mark.skipif(
parse_shebang.find_executable('rustup') is None,
reason='Cargo is not installed in the local environment',
)


@pytest.fixture
def cmd_output_b_mck():
with mock.patch.object(rust, 'cmd_output_b') as mck:
yield mck


@requires_locally_installed_cargo()
def test_sets_system_when_rust_is_available(cmd_output_b_mck):
cmd_output_b_mck.return_value = (0, b'', b'')
assert ACTUAL_GET_DEFAULT_VERSION() == 'system'


@requires_locally_installed_cargo()
def test_uses_default_when_rust_is_not_available(cmd_output_b_mck):
cmd_output_b_mck.return_value = (127, b'', b'error: not found')
assert ACTUAL_GET_DEFAULT_VERSION() == C.DEFAULT


@requires_locally_installed_cargo()
def test_selects_system_even_if_rust_toolchain_toml(tmp_path):
toolchain_toml = '[toolchain]\nchannel = "wtf"\n'
tmp_path.joinpath('rust-toolchain.toml').write_text(toolchain_toml)
Expand Down Expand Up @@ -74,16 +91,17 @@ def mck(exe, env=None):
assert ret == (0, b'Hello, world!\n')


@requires_locally_installed_rustup()
@pytest.mark.parametrize('version', (C.DEFAULT, '1.56.0'))
def test_language_version_with_rustup(tmp_path, version):
assert parse_shebang.find_executable('rustup') is not None

_make_hello_world(tmp_path)

ret = run_language(tmp_path, rust, 'hello_world', version=version)
assert ret == (0, b'Hello, world!\n')


@requires_locally_installed_cargo()
@pytest.mark.parametrize('dep', ('cli:shellharden:4.2.0', 'cli:shellharden'))
def test_rust_cli_additional_dependencies(tmp_path, dep):
_make_local_repo(str(tmp_path))
Expand All @@ -102,6 +120,7 @@ def test_rust_cli_additional_dependencies(tmp_path, dep):
assert ret == (0, b'echo "$hi"\n')


@requires_locally_installed_cargo()
def test_run_lib_additional_dependencies(tmp_path):
_make_hello_world(tmp_path)

Expand Down
Loading