Fix orbitControl() breaking after touch swipe outside canvas.#8863
Merged
Conversation
Closed
17 tasks
ksen0
approved these changes
Jun 2, 2026
vamshi567bh
pushed a commit
to vamshi567bh/p5.js
that referenced
this pull request
Jun 20, 2026
Fix orbitControl() breaking after touch swipe outside canvas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8049
Changes:
p5 listened for
pointerupbut notpointercancel. On Android, swiping a touch outside the canvas firespointercancelinstead ofpointerup, so the pointer was never removed from_activePointers. These stale pointers piled up,touches.lengthnever returned to 1, andorbitControl()(which rotates only whenmovedTouches.length === 1) stopped working. Thanks @inaridarkfox4231 for catching this.Fix: handle
pointercancelto remove the cancelled pointer, refreshtouches, and resetmouseIsPressedwhen no pointers remain.https://editor.p5js.org/aman12345/sketches/Z2wBEt3ka
Screenshots of the change:
PR Checklist
npm run lintpasses