Issue 7126 - "saferepr" to avoid BytesWarning when using --setup-show#7205
Merged
Conversation
bytes parametrize parameters cause error when --setup-show is used and Python is called with -bb flag
bluetech
reviewed
May 9, 2020
bluetech
left a comment
Member
There was a problem hiding this comment.
Thanks for tackling this @lancelote. I left some comments.
Contributor
Author
|
GitLab is down so linting can't succeed, unfortunately. Changes after the review:
@bluetech Thank you for the valuable feedback 🙇🏻♂️ Please feel free to point me to any other improvements I can add here. |
bluetech
reviewed
May 10, 2020
bluetech
left a comment
Member
There was a problem hiding this comment.
Thanks, LGTM, just a couple nits.
I'll leave this open for a few days to let other chime in if they have an opinion about the change to always use repr (I think it makes sense and even in the str case makes it clearer), then I'll merge.
Co-authored-by: Ran Benita <ran@unusedvar.com>
Co-authored-by: Ran Benita <ran@unusedvar.com>
bluetech
approved these changes
May 10, 2020
Zac-HD
approved these changes
May 13, 2020
Zac-HD
left a comment
Member
There was a problem hiding this comment.
Looks good to me - let's merge!
Thanks, @lancelote 😁
Member
|
Thanks everyone for the fix! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #7126
I added a special case for bytes only as
saferepradds quotes to pure string literals. A bunch of tests depend on the original behavior, so I was not comfortable changing it globally. Scrappingsafereproutput to match the original behavior doesn't sound as a trouble-proof solution too. Please correct me if it was a wrong idea.Thank you for your time reviewing the PR 🙏