Skip to content

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API#135021

Merged
encukou merged 1 commit into
python:mainfrom
vstinner:object_delattr
Jun 4, 2025
Merged

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API#135021
encukou merged 1 commit into
python:mainfrom
vstinner:object_delattr

Conversation

@vstinner

@vstinner vstinner commented Jun 2, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jun 2, 2025
Closed
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 2, 2025
@vstinner

vstinner commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka @encukou

serhiy-storchaka
serhiy-storchaka approved these changes Jun 2, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@encukou encukou merged commit c211130 into python:main Jun 4, 2025
47 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 4, 2025

Copy link
Copy Markdown

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2025
@vstinner @miss-islington
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
0433420 
…ed C API (pythonGH-135021)

(cherry picked from commit c211130)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington-app

miss-islington-app Bot commented Jun 4, 2025

Copy link
Copy Markdown

Sorry, @vstinner and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c21113072cd1f0da83729f99d3576647db85d816 3.13

@encukou

encukou commented Jun 4, 2025

Copy link
Copy Markdown
Member

Thank you!

@bedevere-app

bedevere-app Bot commented Jun 4, 2025

Copy link
Copy Markdown

GH-135133 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 4, 2025
@bedevere-app

bedevere-app Bot commented Jun 4, 2025

Copy link
Copy Markdown

GH-135134 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 4, 2025
@vstinner
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
5246905 
…ed C API (pythonGH-135021)

(cherry picked from commit c211130)
@vstinner vstinner deleted the object_delattr branch June 4, 2025 13:33
vstinner added a commit that referenced this pull request Jun 4, 2025
@miss-islington @vstinner
[3.14] gh-134989: Implement PyObject_DelAttr() as a macro in the limi…
da1bbce 
…ted C API (GH-135021) (#135133)

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API (GH-135021)
(cherry picked from commit c211130)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 4, 2025
@vstinner
[3.13] gh-134989: Implement PyObject_DelAttr() as a macro in the limi…
95f6296 
…ted C API (GH-135021) (#135134)

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API (GH-135021)

(cherry picked from commit c211130)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@vstinner @Pranjal095
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
3fc91e1 
…ed C API (pythonGH-135021)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@vstinner @taegyunkim
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
e3d8a43 
…ed C API (pythonGH-135021)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@vstinner @Agent-Hellboy
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
b04a737 
…ed C API (pythonGH-135021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@encukou encukou

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @encukou @serhiy-storchaka