Skip to content

gh-145566: Skip stop-the-world when reassigning __class__ on newly created objects (gh-145567) #145567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Mar 6, 2026
Merged

gh-145566: Skip stop-the-world when reassigning __class__ on newly created objects (gh-145567) #145567

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d63f19b
gh-145566: Skip stop-the-world when reassigning `__class__` on newly …
colesbury Mar 5, 2026
d1012c3
Lock the dict if we're not in a stop-the-world event
colesbury Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Lock the dict if we're not in a stop-the-world event
  • Loading branch information
@colesbury
colesbury committed Mar 5, 2026
commit d1012c3c7112c7dfff26b7fdb637130306ef80fd
6 changes: 5 additions & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7568,7 +7568,11 @@ object_set_class_world_stopped(PyObject *self, PyTypeObject *newto)

assert(_PyObject_GetManagedDict(self) == dict);

if (_PyDict_DetachFromObject(dict, self) < 0) {
int err;
Py_BEGIN_CRITICAL_SECTION(dict);
err = _PyDict_DetachFromObject(dict, self);
Py_END_CRITICAL_SECTION();
if (err < 0) {
return -1;
}

Expand Down
Loading