gh-149567: Remove deprecated shutil.ExecError#149568
Conversation
| self.x | ||
| from shutil import ExecError | ||
| print(ExecError) | ||
| from heapq import heapify_max |
There was a problem hiding this comment.
Turns out it was used somewhere after all! Technically this doesn't matter, but to avoid any potential confusion I changed it to something else.
I confirmed it still fails when 1561385 is reverted.
Documentation build overview
35 files changed ·
|
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM. I believe #123125 was one of my earliest contributions, actually.
Just a heads-up: there are still some people using this. (See the search I referred to in the original deprecation issue.) I'm not super worried about it, considering we were emitting a warning, but it's definitely worth noting.
|
|
This and some other removals are still listed in "Pending removal in Python 3.16". https://docs.python.org/3.16/deprecations/index.html#pending-removal-in-python-3-16 Please could you remove them? |
|
Oh, I thought the guideline was to keep them there and then the entire file would be removed at some point? Or I may be misremembering. |
|
I don't recall either! But https://docs.python.org/3.16/deprecations/index.html#pending-removal-in-python-3-16 is out of date for the 3.16 docs, when they've also been listed as removed at https://docs.python.org/3.16/whatsnew/3.16.html#removed (and removed in code). If we update https://docs.python.org/3.16/deprecations/index.html#pending-removal-in-python-3-16 as we go, it's a good TODO list of what's left to remove. |
shutil.ExecError#149567