Skip to content

gh-152434: Fix async-aware Gecko collection#152442

Merged
pablogsal merged 3 commits into
python:mainfrom
lkollar:tachyon/gecko-async-fix
Jun 27, 2026
Merged

gh-152434: Fix async-aware Gecko collection#152442
pablogsal merged 3 commits into
python:mainfrom
lkollar:tachyon/gecko-async-fix

Conversation

@lkollar

@lkollar lkollar commented Jun 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Reuse the existing async flattening code to flatten the task graph into frame stacks.

@lkollar lkollar requested a review from pablogsal as a code owner June 27, 2026 16:18
@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2026
Open
@pablogsal pablogsal added skip news needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 27, 2026
@pablogsal

pablogsal commented Jun 27, 2026

Copy link
Copy Markdown
Member

@lkollar reviewing, meanwhile, can you add a news entry?

lkollar added 2 commits June 27, 2026 17:56
@lkollar
Fix async-aware Gecko collection
8d02680 
Reuse the existing async flattening code to flatten the task graph into
frame stacks.
@lkollar
Add news entry
97b34bb
@lkollar lkollar force-pushed the tachyon/gecko-async-fix branch from 8a77e03 to 97b34bb Compare June 27, 2026 16:56
pablogsal
pablogsal approved these changes Jun 27, 2026
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a small refactor doing the batched timestamp check

@pablogsal pablogsal enabled auto-merge (squash) June 27, 2026 17:02
@pablogsal

pablogsal commented Jun 27, 2026

Copy link
Copy Markdown
Member

@lkollar the ecmascripten test failure seems to be realk can you take a look?

@pablogsal pablogsal merged commit 87ac0bc into python:main Jun 27, 2026
54 of 55 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

Thanks @lkollar for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

GH-152450 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 27, 2026
pablogsal pushed a commit that referenced this pull request Jun 27, 2026
@miss-islington @lkollar
[3.15] gh-152434: Fix async-aware Gecko collection (GH-152442) (#152450)
68abb37 
gh-152434: Fix async-aware Gecko collection (GH-152442)
(cherry picked from commit 87ac0bc)

Co-authored-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
@pablogsal

pablogsal commented Jun 28, 2026

Copy link
Copy Markdown
Member

Crap ecma was not a required target. @lkollar can you create a follow up or with a fix?

@pablogsal

pablogsal commented Jun 28, 2026

Copy link
Copy Markdown
Member

Never mind doing one because this is blocking ci

@lkollar lkollar deleted the tachyon/gecko-async-fix branch June 28, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lkollar @pablogsal