gh-152492 Allow OrderedDict.update to work with frozendict#152494
Open
da-woods wants to merge 5 commits into
Open
gh-152492 Allow OrderedDict.update to work with frozendict#152494da-woods wants to merge 5 commits into
da-woods wants to merge 5 commits into
Conversation
Additionally, add tests for comparison with frozendict on the same basis as dict. This already worked but is good to confirm.
Contributor
|
This looks reasonable. Please fix-up the failing doc tests. |
Contributor
Author
Done |
sobolevn
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, add tests for comparison with frozendict on the same basis as dict. This already worked but is good to confirm.
updatedoesn't accept frozendict objects #152492