gh-152503: Fix garbage text from curses wide-character cell reads#152505
Merged
Conversation
window.in_wch(), window.in_wchstr() and window.getbkgrnd() read a cell into an uninitialized cchar_t, relying on the curses library to leave the text NUL-terminated -- which ncurses does but X/Open does not require, so some libraries (such as NetBSD curses) returned uninitialized bytes as wide characters. Zero-initialize the cell buffers before the read and default the getcchar() output to an empty string. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.in_wch(),window.in_wchstr()andwindow.getbkgrnd()read a cell into an uninitializedcchar_tand rely on the curses library leaving the text NUL-terminated — which ncurses does but X/Open does not require, so libraries such as NetBSD curses returned uninitialized bytes as wide characters (surfacing asValueErrorfor out-of-range code points).Zero-initialize the cell buffers before the read (
in_wch,getbkgrnd,in_wchstr) and default thegetcchar()output to an empty string, sincegetcchar()need not write the text of an empty cell.No-op on ncurses;
test_curseskeeps passing and stays refleak-clean.🤖 Generated with Claude Code