Skip to content

fix: handle large number of approval rules#2866

Merged
nejch merged 1 commit into
mainfrom
jlvillal/issue_2825
May 17, 2024
Merged

fix: handle large number of approval rules#2866
nejch merged 1 commit into
mainfrom
jlvillal/issue_2825

Conversation

@JohnVillalovos

Copy link
Copy Markdown
Member

Use iterator=True when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules.

Closes: #2825

@nejch nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thanks!

@nejch nejch enabled auto-merge (rebase) May 17, 2024 10:05
Use `iterator=True` when going through the list of current approval
rules. This allows it to handle more than the default of 20 approval
rules.

Closes: #2825
@nejch nejch force-pushed the jlvillal/issue_2825 branch from 3618a7c to 0f30a6f Compare May 17, 2024 10:06
@nejch nejch merged commit ef8f0e1 into main May 17, 2024
@nejch nejch deleted the jlvillal/issue_2825 branch May 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProjectMergeRequestApprovalManager.set_approvers cannot handle too many approval rules

2 participants