fix(cli): generate UserWarning if list does not return all entries#2901
Merged
Conversation
05c0c70 to
09b9205
Compare
nejch
reviewed
Jul 3, 2024
nejch
left a comment
Member
There was a problem hiding this comment.
THanks a lot @JohnVillalovos, I've been thinking about this one for a bit because we reintroduce more CLI logic into the API client, and I wonder if there's a more generic way. Just a tiny idea below 🙇
This allows us to not add the caller's location to the UserWarning message.
Previously in the CLI, calls to `list()` would have `get_all=False` by default. Therefore hiding the fact that not all items are being returned if there were more than 20 items. Added `--no-get-all` option to `list` actions. Along with the already existing `--get-all`. Closes: #2900
09b9205 to
e1e0060
Compare
Member
Author
@nejch thanks for the review. I have updated it to pass in a WarnMessageData object. So I think it will do what you want. |
nejch
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in the CLI, calls to
list()would haveget_all=Falsebydefault. Therefore hiding the fact that not all items are being
returned if there were more than 20 items.
Added
--no-get-alloption tolistactions. Along with the alreadyexisting
--get-all.Closes: #2900