Allow SSL connections to older devices#1654
Merged
Merged
Conversation
With recent firmware updates for older devices (like C120) the embedded SSL certificate on the deivce is RSA 1024 type, which is considered insecure nowadays. 0 s:CN=TPRI-DEVICE, O=TPRI, C=US i:CN=TPRI-DEVICE, O=TPRI, C=US a:PKEY: RSA, 1024 (bit); sigalg: sha256WithRSAEncryption v:NotBefore: Jan 1 00:00:00 2001 GMT; NotAfter: Dec 31 23:59:59 2070 GMT This fix add cipher used by TP-Link to list of allowed ones. Related: home-assistant/core#162498 Signed-off-by: Alexander D. Kanevskiy <kad@kad.name>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1654 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 157 157
Lines 9649 9649
Branches 976 976
=======================================
Hits 8957 8957
Misses 492 492
Partials 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yes, this fixed authentication issues I was having with my Tapo P100! Top job <3 |
Contributor
Author
|
@rytilahti would it be possible please to cut release for python-kasa, so the HomeAssistant would be adopting it as an updated dependency? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent firmware updates for older devices (like C120) the embedded SSL certificate on the deivce is RSA 1024 type, which is considered insecure nowadays.
0 s:CN=TPRI-DEVICE, O=TPRI, C=US
i:CN=TPRI-DEVICE, O=TPRI, C=US
a:PKEY: RSA, 1024 (bit); sigalg: sha256WithRSAEncryption
v:NotBefore: Jan 1 00:00:00 2001 GMT; NotAfter: Dec 31 23:59:59 2070 GMT
This fix add cipher used by TP-Link to list of allowed ones.
Related: home-assistant/core#162498