Add WhiteLamp SmartCam module for outdoor cameras (e.g. C325WB)#1713
Open
ijardillier wants to merge 2 commits into
Open
Add WhiteLamp SmartCam module for outdoor cameras (e.g. C325WB)#1713ijardillier wants to merge 2 commits into
ijardillier wants to merge 2 commits into
Conversation
- New WhiteLamp module under kasa/smartcam/modules/ - Exposes white_lamp_state (on/off toggle via reverseWhitelampStatus) and white_lamp_brightness (1-100, only if device supports it) - Adds Module.SmartCamWhiteLamp and Module.WhiteLamp module names - Adds fixture for C325WB(EU) 1.0 / 1.4.4 - Adds unit tests in tests/smartcam/modules/test_whitelamp.py - Fixes fake protocol to handle reverseWhitelampStatus toggle command
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
+ Coverage 93.22% 93.24% +0.01%
==========================================
Files 157 158 +1
Lines 9815 9854 +39
Branches 1003 1005 +2
==========================================
+ Hits 9150 9188 +38
Misses 472 472
- Partials 193 194 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
to match the class name used as key in dev.modules - Add SmartCamModule.SmartCamWhiteLamp assertion in test_whitelamp_is_on - Add test_whitelamp_no_brightness to cover the case where brightness is not supported by the device"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New WhiteLamp module under kasa/smartcam/modules/
Pre-commit OK
Tests : OK
Also tested with python-kasa CLI and my own Home Assistant instance with 2 C325WB cameras.
Hope all is compliant with your guidelines and nothing missing.