add analysis metadata parameter to set initial sigma value used in LatGaussFitFR fitting#1683
Open
barentine wants to merge 4 commits into
Open
add analysis metadata parameter to set initial sigma value used in LatGaussFitFR fitting#1683barentine wants to merge 4 commits into
barentine wants to merge 4 commits into
Conversation
…nitial sigma during fitting
|
|
||
| if fitBackground: | ||
| startParameters = [A, x0, y0, 250/2.35, dataMean.min(), .001, .001] | ||
| startParameters = [A, x0, y0, self.metadata['Analysis.SigmaGuess'], dataMean.min(), .001, .001] |
Contributor
There was a problem hiding this comment.
Suggested change
| startParameters = [A, x0, y0, self.metadata['Analysis.SigmaGuess'], dataMean.min(), .001, .001] | |
| startParameters = [A, x0, y0, self.metadata.get('Analysis.PSFSigmaGuess', 250/2.35), dataMean.min(), .001, .001] |
- keep backwards compatibility for re-analysis with old metadata (
PARAMETERSis mostly a GUI niceity) - make naming line up with, e.g.
GaussMultifit
Contributor
There was a problem hiding this comment.
Obviously needs corresponding changes to other usages
Member
Author
There was a problem hiding this comment.
I think we'll want to do metadata.getOrDefault, but otherwise appreciate the suggestion to switch style, stick with the naming convention, etc.
Contributor
|
I wonder if we should add this to other Gaussian fits at the same time (ie |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Addresses issue: if you are using LatGaussFitFR.py to fit e.g. large beads imaged on low NA setup, rather than single molecules on high NA oil immersion, you'd like to change the initial sigma value.
Is this a bugfix or an enhancement?
enhancement
Proposed changes:
Checklist:
The below is a list of things what will be considered when reviewing PRs. It is not prescriptive, and does not
imply that PRs which touch any of these will be rejected but gives a rough indication of where there is a potential
for hangups (i.e. factors which could turn a 5 min review into a half hour or longer and shunt it to the bottom
of the TODO list).
much simpler if this is kept separate from functional changes. The auto-formatting performed by some editors is particulaly egregious and can lead to files with thousands
of non-functional changes with a few functional changes scattered amoungst them]
If an enhancement (or non-trivial bugfix):