Moved version string to folium/__init__.py.#60
Merged
Conversation
Contributor
|
@ocefpaf looks good, i promise i am reviewing these lol ✋ swear! we are supporting python3? ill wait for travis like a good boy |
Member
Author
|
Yes we are @birdage! https://travis-ci.org/python-visualization/folium/builds/43008762 BTW: I will cut the new release as soon as you press the merge button! PS: And I promise to always keep my PRs tiny and easy to review 😉 |
Contributor
|
@ocefpaf NICE! |
birdage
added a commit
that referenced
this pull request
Dec 4, 2014
Moved version string to `folium/__init__.py`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible check the module version via:
That is important for projects that needs to freeze or check what version is being used.
@birdage Care to review? That is my last commit before the new release!
PS: It also pep8'd
setup.pyand added python 3 to the classifiers.