[FIX] pre-commit broken in scale plugin - #112
Merged
Merged
Conversation
Contributor
Author
|
ping @carmenbianca @huguesdk Can one of you validate that I did not break anything with the addition of the Flake8 did not like that |
huguesdk
approved these changes
Oct 10, 2022
huguesdk
left a comment
Contributor
There was a problem hiding this comment.
great idea to put the read loop in a separate function, it’s much cleaner. thanks!
apart from the comments about the stx variable, looks good to me.
Co-authored-by: hugues de keyzer <odoo@hugues.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.