Skip to content

1606 Drop named item types, refine named record types, esp in XSLT - #1617

Closed
michaelhkay wants to merge 2 commits into
qt4cg:masterfrom
michaelhkay:1606-named-records-supersede-named-item-types
Closed

1606 Drop named item types, refine named record types, esp in XSLT#1617
michaelhkay wants to merge 2 commits into
qt4cg:masterfrom
michaelhkay:1606-named-records-supersede-named-item-types

Conversation

@michaelhkay

Copy link
Copy Markdown
Contributor

Fix #1606
Fix #1506
Fix #1485

This PR drops the general concept of declaring named item types in XQuery and XSLT, and focuses on declaring named record types. The rules for named record types are tidied up editorially in XQuery (for example there is a clearer distinction between the syntax production RecordType and the concept of a record type, which can be declared either using that syntax, or otherwise). In XSLT the <xsl:item-type> declaration is dropped and an <xsl:record-type> declaration is introduced.

@michaelhkay michaelhkay added XQuery An issue related to XQuery XSLT An issue related to XSLT Feature A change that introduces a new feature Tests Needed Tests need to be written or merged Decluttering Cut out dead wood labels Nov 27, 2024

@ChristianGruen ChristianGruen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread specifications/xquery-40/src/query-prolog.xml Outdated
@michaelhkay

Copy link
Copy Markdown
Contributor Author

forward vs. forwards?

https://english.stackexchange.com/questions/3885/forward-vs-forwards

I struggle with subtle distinctions like this because I'm not a native speaker of American.

@michaelhkay
michaelhkay force-pushed the 1606-named-records-supersede-named-item-types branch from 366c97d to 98e1a0b Compare December 3, 2024 18:03
@michaelhkay

Copy link
Copy Markdown
Contributor Author

There was inconclusive discussion of this on 17 Dec 2024. Some felt that named item types (other than record types) were a useful feature and were reluctant to see them go, although the duplication was recognised as being potentially confusing.

@michaelhkay
michaelhkay force-pushed the 1606-named-records-supersede-named-item-types branch from 98e1a0b to b6e4159 Compare January 6, 2025 15:19
@michaelhkay michaelhkay added the Blocked PR is blocked (has merge conflicts, doesn't format, etc.) label Jan 7, 2025
@michaelhkay michaelhkay added the Abandoned PR was rejected, withdrawn, or superseded label Jan 16, 2025
@michaelhkay

Copy link
Copy Markdown
Contributor Author

Closed as abandoned. Superseded by #1708 for the XSLT parts.

@michaelhkay michaelhkay removed Feature A change that introduces a new feature Blocked PR is blocked (has merge conflicts, doesn't format, etc.) Tests Needed Tests need to be written or merged Decluttering Cut out dead wood labels Jan 17, 2025
@michaelhkay

michaelhkay commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Note: Named item types were included in the baseline draft adopted by the Community Group when it started work, and were thus not added by any specific PR. This PR, which attempted to remove them but failed, is now being referenced from the specification and from test cases as the definitive PR for the xsl:item-type feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Abandoned PR was rejected, withdrawn, or superseded XQuery An issue related to XQuery XSLT An issue related to XSLT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop named item types other than named record types Type declarations: Constructor functions? Record declarations in XSLT

2 participants