Issue 314 array composition and decomposition - #360
Closed
michaelhkay wants to merge 2 commits into
Closed
Conversation
Contributor
|
Accepted at meeting 027 Close #314 |
ndw
added a commit
to ndw/qtspecs-xslt4
that referenced
this pull request
Mar 21, 2023
ndw
added a commit
that referenced
this pull request
Mar 21, 2023
MK PR #360 with merge conflicts resolved (array compositionand decomposition)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses parts of issue 29, issue 113, and issue 314 relating to the composition and decomposition of arrays.
It introduces two functions
array:offor array composition, andarray:membersfor decomposition, and defines all other array functions in terms of these two primitives (replacing the internal functionsop:A2Sandop:S2A). The items in the decomposed form of an array are called "value records", singleton maps of the formmap{'value': $value}The function
array:from-sequenceis renamedarray:buildto reflect its symmetry withmap:build.Question for the group: should we have a new function for constructing a "value record", or is the syntax
map{'value': $value}adequate for the purpose?