989 (partial) Allow char() to take integer argument - #993
Merged
Conversation
ChristianGruen
approved these changes
Feb 2, 2024
ChristianGruen
left a comment
Contributor
There was a problem hiding this comment.
I think it won't be a mistake to still allow #x20.
ChristianGruen
approved these changes
Feb 3, 2024
Contributor
…after a second thought, I now think they’re superfluous. Let’s see what others think. |
Contributor
|
The CG agreed to merge this issue at meeting 064 |
Contributor
Author
|
Added the agreed changes. The forms char('#32`) and char('#x20') are dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the use case in issue #989. (But leave the issue open for now).
Discussion point: should we drop the options
char("#32")andchar("#x20")as they now seem redundant?