149 View cache#178
Merged
Merged
Conversation
armanist
requested changes
Nov 14, 2024
armanist
left a comment
Collaborator
There was a problem hiding this comment.
First please look at scrutinizer issues and fix them.
The library uses code PHP functionality, but instead it should use every available functions from framework.
The approach of storing ttl into the content is not desirable
serializing the content can lead potential problems
Arno2005
reviewed
Nov 15, 2024
Arno2005
reviewed
Nov 15, 2024
Arno2005
suggested changes
Nov 15, 2024
Arno2005
left a comment
Collaborator
There was a problem hiding this comment.
Add the missing doc blocks and remove duplicate unit tests.
armanist
requested changes
Nov 15, 2024
armanist
requested changes
Nov 27, 2024
armanist
requested changes
Nov 27, 2024
armanist
requested changes
Nov 28, 2024
armanist
requested changes
Nov 30, 2024
armanist
left a comment
Collaborator
There was a problem hiding this comment.
The latest changes introduced some inconsistencies..
The ttl property of ViewCache is set from Route class while isEnabled is set from Router class.
We need to keep consistency on similar operations applied on same object.
It's obvious now that these both things (ttl and isEnabled) should be set from Router class after the current route is known. Therefore there would no need of passing ViewCache instance to Route class anymore.
armanist
approved these changes
Dec 2, 2024
andrey-smaelov
approved these changes
Dec 2, 2024
Arno2005
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.