Skip to content

310 refactor join system#311

Merged
armanist merged 5 commits into
quantum-php:masterfrom
armanist:310-Refactor-Join-System
Jul 28, 2025
Merged

310 refactor join system#311
armanist merged 5 commits into
quantum-php:masterfrom
armanist:310-Refactor-Join-System

Conversation

@armanist

@armanist armanist commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

Closes #310

@armanist armanist added this to the 2.9.8 milestone Jul 28, 2025
@armanist armanist added enhancement New feature or request help wanted Extra attention is needed labels Jul 28, 2025
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.50%. Comparing base (fa12806) to head (e93e5fd).

Files with missing lines Patch % Lines
...aries/Database/Adapters/Idiorm/Statements/Join.php 95.83% 1 Missing ⚠️
...ries/Database/Adapters/Sleekdb/Statements/Join.php 96.15% 1 Missing ⚠️
src/Paginator/Factories/PaginatorFactory.php 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
+ Coverage     80.46%   80.50%   +0.03%     
- Complexity     2480     2489       +9     
============================================
  Files           227      227              
  Lines          6347     6359      +12     
============================================
+ Hits           5107     5119      +12     
  Misses         1240     1240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

grigoryanmartin20
grigoryanmartin20 approved these changes Jul 28, 2025
View reviewed changes

@grigoryanmartin20 grigoryanmartin20 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the file version to 2.9.8.
src/Libraries/Session/Adapters/Database/DatabaseSessionAdapter.php

andrey-smaelov
andrey-smaelov approved these changes Jul 28, 2025
View reviewed changes
Comment thread src/Libraries/Cache/Adapters/DatabaseAdapter.php
@armanist armanist merged commit a121649 into quantum-php:master Jul 28, 2025
3 checks passed
@armanist armanist deleted the 310-Refactor-Join-System branch July 28, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrey-smaelov andrey-smaelov andrey-smaelov approved these changes
@hatik92 hatik92 Awaiting requested review from hatik92
@live-soft live-soft Awaiting requested review from live-soft
@Arno2005 Arno2005 Awaiting requested review from Arno2005
+1 more reviewer
@grigoryanmartin20 grigoryanmartin20 grigoryanmartin20 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Milestone

2.9.8

Development

Successfully merging this pull request may close these issues.

Refactor Join System

3 participants

@armanist @andrey-smaelov @grigoryanmartin20