Skip to content

400 make http client testable by allowing curl and multi curl injection and removing external api dependency from tests#401

Merged
armanist merged 3 commits into
quantum-php:masterfrom
armanist:400-Make-HttpClient-testable-by-allowing-Curl-and-MultiCurl-injection-and-removing-external-API-dependency-from-tests
Jan 13, 2026
Merged

400 make http client testable by allowing curl and multi curl injection and removing external api dependency from tests#401
armanist merged 3 commits into
quantum-php:masterfrom
armanist:400-Make-HttpClient-testable-by-allowing-Curl-and-MultiCurl-injection-and-removing-external-API-dependency-from-tests

Conversation

@armanist

Copy link
Copy Markdown
Collaborator

Closes #400

…on and removing external API dependency from tests
…-allowing-Curl-and-MultiCurl-injection-and-removing-external-API-dependency-from-tests
@armanist armanist added this to the 3.0.0 milestone Jan 13, 2026
@armanist armanist added the enhancement New feature or request label Jan 13, 2026
@codecov

codecov Bot commented Jan 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.66%. Comparing base (fb03a39) to head (7769c31).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
- Coverage     80.72%   80.66%   -0.07%     
- Complexity     2467     2470       +3     
============================================
  Files           229      229              
  Lines          6543     6543              
============================================
- Hits           5282     5278       -4     
- Misses         1261     1265       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@armanist armanist merged commit 697d4fc into quantum-php:master Jan 13, 2026
5 of 6 checks passed
@armanist armanist deleted the 400-Make-HttpClient-testable-by-allowing-Curl-and-MultiCurl-injection-and-removing-external-API-dependency-from-tests branch January 13, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make HttpClient testable by allowing Curl and MultiCurl injection and removing external API dependency from tests

2 participants