Skip to content

Improve serve Command Reliability#406

Merged
armanist merged 2 commits into
quantum-php:masterfrom
armanist:399-Improve-serve-Command-Reliability
Jan 15, 2026
Merged

Improve serve Command Reliability#406
armanist merged 2 commits into
quantum-php:masterfrom
armanist:399-Improve-serve-Command-Reliability

Conversation

@armanist

Copy link
Copy Markdown
Collaborator

Closes #399

@armanist armanist added this to the 3.0.0 milestone Jan 14, 2026
@armanist armanist added the enhancement New feature or request label Jan 14, 2026
@armanist armanist requested review from a team, Wiltzsu and andrey-smaelov January 14, 2026 15:49
@codecov

codecov Bot commented Jan 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.90%. Comparing base (c2efe7a) to head (0dccf49).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/Console/Commands/ServeCommand.php 0.00% 94 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #406      +/-   ##
============================================
- Coverage     80.67%   79.90%   -0.77%     
- Complexity     2472     2492      +20     
============================================
  Files           229      229              
  Lines          6546     6609      +63     
============================================
  Hits           5281     5281              
- Misses         1265     1328      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrey-smaelov andrey-smaelov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server not binds next available port if second server is run, this creates serious issue.

Steps to reproduce:

  1. Run php qt serve -o
    This will run the php server and will open browser on http://127.0.0.1:8000
  2. Run second time php qt serve -o
    Same way browser is opened but still on http://127.0.0.1:8000

Expected behavior:

Second server should be run on port 8001

@armanist armanist requested a review from charoyan88 January 15, 2026 10:32
@armanist armanist merged commit 5f481a5 into quantum-php:master Jan 15, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve serve Command Reliability

3 participants