Skip to content

Adding types to class properties, updating method signatures, and organizing use statements across multiple classes and packages.#422

Merged
armanist merged 3 commits into
quantum-php:masterfrom
armanist:421-Add-Type-Declarations-and-Improve-Code-Quality-with-Rector
Mar 11, 2026
Merged

Adding types to class properties, updating method signatures, and organizing use statements across multiple classes and packages.#422
armanist merged 3 commits into
quantum-php:masterfrom
armanist:421-Add-Type-Declarations-and-Improve-Code-Quality-with-Rector

Conversation

@armanist

@armanist armanist commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

Closes #421

@armanist
Adding types to class properties, updating method signatures, and org…
4d814a2 
…anizing use statements across multiple classes and packages.
@coderabbitai

coderabbitai Bot commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d97ec45a-6f1b-41b9-9356-b5dea83b9fe1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.46774% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.60%. Comparing base (77cb42d) to head (6e554c1).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Migration/MigrationManager.php 0.00% 7 Missing ⚠️
src/Console/Commands/OpenApiCommand.php 0.00% 3 Missing ⚠️
src/Database/Adapters/Sleekdb/SleekDbal.php 50.00% 3 Missing ⚠️
src/Logger/Logger.php 66.66% 3 Missing ⚠️
src/Console/Commands/DebugBarCommand.php 0.00% 2 Missing ⚠️
src/Console/Commands/ResourceCacheClearCommand.php 0.00% 2 Missing ⚠️
src/Debugger/Debugger.php 71.42% 2 Missing ⚠️
src/Mailer/Adapters/SmtpAdapter.php 83.33% 2 Missing ⚠️
src/Migration/MigrationTable.php 0.00% 2 Missing ⚠️
src/App/Traits/AppTrait.php 0.00% 1 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #422   +/-   ##
=========================================
  Coverage     82.59%   82.60%           
+ Complexity     2719     2715    -4     
=========================================
  Files           241      241           
  Lines          7298     7290    -8     
=========================================
- Hits           6028     6022    -6     
+ Misses         1270     1268    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrey-smaelov andrey-smaelov added the help wanted Extra attention is needed label Mar 9, 2026
@andrey-smaelov andrey-smaelov added this to the 3.0.0 milestone Mar 9, 2026
andrey-smaelov
andrey-smaelov reviewed Mar 9, 2026
View reviewed changes

@andrey-smaelov andrey-smaelov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the @var docblock is redundant when the type is already declared natively.

@armanist armanist requested a review from andrey-smaelov March 9, 2026 16:34
andrey-smaelov
andrey-smaelov requested changes Mar 10, 2026
View reviewed changes
Comment thread src/Migration/MigrationManager.php
Comment thread src/Storage/Traits/CloudAppTrait.php Outdated
@armanist armanist requested a review from andrey-smaelov March 10, 2026 16:22
@armanist armanist merged commit d6252a0 into quantum-php:master Mar 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charoyan88 charoyan88 Awaiting requested review from charoyan88
@Arno2005 Arno2005 Awaiting requested review from Arno2005
@Wiltzsu Wiltzsu Awaiting requested review from Wiltzsu
@andrey-smaelov andrey-smaelov Awaiting requested review from andrey-smaelov

Assignees

No one assigned

Labels

help wanted Extra attention is needed

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Add Type Declarations and Improve Code Quality with Rector

2 participants

@armanist @andrey-smaelov