Skip to content

Making sure to remove 'id' from user data#425

Merged
armanist merged 1 commit into
quantum-php:masterfrom
armanist:master
Mar 15, 2026
Merged

Making sure to remove 'id' from user data#425
armanist merged 1 commit into
quantum-php:masterfrom
armanist:master

Conversation

@armanist

@armanist armanist commented Mar 15, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where primary key values could be unintentionally modified during user profile updates.

@coderabbitai

coderabbitai Bot commented Mar 15, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ac06d93-1b33-4d00-8dee-1eda22d529f7

📥 Commits

Reviewing files that changed from the base of the PR and between b574c6c and f7a26e1.

📒 Files selected for processing (2)
  • src/Module/Templates/DemoApi/src/Services/AuthService.php.tpl
  • src/Module/Templates/DemoWeb/src/Services/AuthService.php.tpl
📝 Walkthrough

Walkthrough

Two template files receive identical updates to prevent id field modifications during user data updates via mass-assignment, safeguarding primary key integrity in the update method.

Changes

Cohort / File(s) Summary
AuthService Template Updates
src/Module/Templates/DemoApi/src/Services/AuthService.php.tpl, src/Module/Templates/DemoWeb/src/Services/AuthService.php.tpl		 Both files unset the id field from the data array before model assignment in the update method, preventing inadvertent primary key modifications during mass-assignment operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The id field was wandering free,
But we said "no, you must not be!
With unset's might, so clean and bright,
The primary key stays locked up tight!" 🔐

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: removing the 'id' field from user data in the update methods of both AuthService template files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@armanist armanist merged commit bc8afc2 into quantum-php:master Mar 15, 2026
5 checks passed
@codecov

codecov Bot commented Mar 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.62%. Comparing base (b574c6c) to head (f7a26e1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #425   +/-   ##
=========================================
  Coverage     82.62%   82.62%           
  Complexity     2717     2717           
=========================================
  Files           241      241           
  Lines          7298     7298           
=========================================
  Hits           6030     6030           
  Misses         1268     1268

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@armanist