Skip to content

Changing the getPagination method first value to be boolean to follow…#430

Merged
andrey-smaelov merged 1 commit into
quantum-php:masterfrom
armanist:master
Mar 17, 2026
Merged

Changing the getPagination method first value to be boolean to follow…#430
andrey-smaelov merged 1 commit into
quantum-php:masterfrom
armanist:master

Conversation

@armanist

@armanist armanist commented Mar 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

… strict type declaration

Summary by CodeRabbit

  • Refactor
    • Updated pagination parameters across multiple page templates to improve code consistency and type handling.

@armanist armanist added the bug Something isn't working label Mar 17, 2026
@armanist armanist added this to the 3.0.0 milestone Mar 17, 2026
@armanist armanist requested a review from andrey-smaelov March 17, 2026 09:40
@coderabbitai

coderabbitai Bot commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3cccb2a-e30e-40a8-87f7-d2fb1ed78dae

📥 Commits

Reviewing files that changed from the base of the PR and between d57cea0 and 83835bd.

📒 Files selected for processing (4)
  • src/Module/Templates/DemoWeb/src/Views/post/post.php.tpl
  • src/Module/Templates/Toolkit/src/Views/pages/database/table.php.tpl
  • src/Module/Templates/Toolkit/src/Views/pages/email/index.php.tpl
  • src/Module/Templates/Toolkit/src/Views/pages/logs/log.php.tpl
📝 Walkthrough

Walkthrough

Pagination function calls refactored across four template files, converting numeric arguments (0, 1) to boolean equivalents (false, true) as the first parameter of getPagination() calls, while the second parameter remains constant.

Changes

Cohort / File(s) Summary
DemoWeb Post Template
src/Module/Templates/DemoWeb/src/Views/post/post.php.tpl		 Changed first argument of pagination call from 0 to false in getPagination().
Toolkit View Templates
src/Module/Templates/Toolkit/src/Views/pages/database/table.php.tpl, src/Module/Templates/Toolkit/src/Views/pages/email/index.php.tpl, src/Module/Templates/Toolkit/src/Views/pages/logs/log.php.tpl		 Standardized first argument of pagination calls from 1 to true in getPagination() across database table, email list, and log views.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Four templates beaming bright and clear,
Their pagination params held most dear,
From ones and zeros, booleans take the stage,
A rabbit's refactoring marks this page,
True and false now lead the way!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the main change—converting getPagination method's first parameter from integer to boolean for type compliance—which aligns with the changeset across four template files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@codecov

codecov Bot commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.63%. Comparing base (d57cea0) to head (83835bd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #430   +/-   ##
=========================================
  Coverage     82.63%   82.63%           
  Complexity     2719     2719           
=========================================
  Files           241      241           
  Lines          7300     7300           
=========================================
  Hits           6032     6032           
  Misses         1268     1268

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrey-smaelov andrey-smaelov merged commit 28ae4b0 into quantum-php:master Mar 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrey-smaelov andrey-smaelov andrey-smaelov approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@armanist @andrey-smaelov