Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/Database/Helpers/db.php (1)

23-30: Guard against function redeclaration.

Global helper files are prone to being loaded more than once (e.g., Composer files autoload + a helper-loader stage, or during test bootstrapping). Without a function_exists() guard, a duplicate load will trigger a fatal Cannot redeclare db() error. Recommend wrapping the definition:

🛡️ Proposed fix

 use Quantum\Database\Database;
 use Quantum\Di\Di;

-/**
- * Gets the Database instance from DI
- */
-function db(): Database
-{
-    if (!Di::isRegistered(Database::class)) {
-        Di::register(Database::class);
-    }
-
-    return Di::get(Database::class);
-}
+if (!function_exists('db')) {
+    /**
+     * Gets the Database instance from DI
+     */
+    function db(): Database
+    {
+        if (!Di::isRegistered(Database::class)) {
+            Di::register(Database::class);
+        }
+
+        return Di::get(Database::class);
+    }
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Database/Helpers/db.php` around lines 23 - 30, Wrap the global helper
function db() with a function_exists check to prevent fatal redeclaration;
specifically, before defining function db() (which uses Di::isRegistered,
Di::register and Di::get with Database::class), add a guard like if
(!function_exists('db')) { /* define function db() here */ } so the helper can
be loaded multiple times safely without redefining db().

tests/Unit/Database/Helpers/DbHelperTest.php (2)

10-13: Redundant setUp() override.

The override only calls parent::setUp() and can be removed for brevity. Non-blocking.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Unit/Database/Helpers/DbHelperTest.php` around lines 10 - 13, Remove
the redundant setUp() override in the DbHelperTest class: the current setUp()
method only calls parent::setUp() and can be deleted to simplify the test class;
locate the public function setUp(): void in DbHelperTest and remove that method
so the parent implementation is used directly.

---

15-26: Consider adding coverage for the lazy-registration branch.

Both existing tests exercise the already-registered path after AppTestCase bootstrapping. A test that resets the DI container (or unregisters Database::class) before calling db() would exercise the !Di::isRegistered(...) branch in src/Database/Helpers/db.php (Lines 25–27), which is currently not directly verified.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Unit/Database/Helpers/DbHelperTest.php` around lines 15 - 26, Add a
unit test that resets the DI registration before calling db() to cover the
lazy-registration branch: in DbHelperTest add a new test (e.g.,
testDbHelperLazilyRegistersDatabase) that unregisters Database::class from the
container (or resets Di) after AppTestCase bootstrapping, then calls db() and
asserts it returns an instance of Database and that the container now has
Database::class registered; reference the db() helper, Di::isRegistered/Di
unregister behavior, and Database::class to locate the code paths in
src/Database/Helpers/db.php.

tests/Unit/View/ViewTest.php (1)

120-122: Line-ending normalization is fine, but consider normalizing the expected string instead.

Mutating $renderedView before assertion masks what the renderer actually produced. An equivalent and clearer approach is to normalize both sides (or just the expected side) using PHP_EOL. Non-blocking; matches the pattern already used in testRenderViewWithTwig on Line 187, so consistency-wise this is acceptable.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/Unit/View/ViewTest.php` around lines 120 - 122, Instead of mutating
$renderedView before the assertion, normalize the expected string to use PHP_EOL
(consistent with testRenderViewWithTwig) so the assertion compares the raw
renderer output to a normalized expected value; update the assertion in ViewTest
(the $renderedView variable and the assertEquals call) to remove the str_replace
on $renderedView and apply PHP_EOL normalization to the expected HTML string
used in assertEquals.