[#482] Expand migration package unit test coverage by armanist · Pull Request #487 · quantum-php/framework

armanist · 2026-04-30T16:16:00Z

Closes #482

Summary by CodeRabbit

Tests
- Added comprehensive unit test coverage for database migration functionality, including tests for migration manager operations (creation, application, upgrades, and downgrades), migration table schema validation, and migration template generation for create, alter, rename, and drop operations.

coderabbitai · 2026-04-30T16:16:15Z

Warning

Rate limit exceeded

@armanist has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 33 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0952f033-a7a4-400c-9309-a8867f090163

📥 Commits

Reviewing files that changed from the base of the PR and between 446c447 and 43d3c6b.

📒 Files selected for processing (1)

tests/Unit/Migration/MigrationManagerTest.php

📝 Walkthrough

Walkthrough

Three new PHPUnit unit test files expand the Migration package test suite: MigrationManagerTest covers constructor behavior, migration generation, and upgrade/downgrade operations; MigrationTableTest validates schema creation and teardown; MigrationTemplateTest verifies template string generation for create, alter, rename, and drop operations. Total: 348 lines of test code.

Changes

Cohort / File(s)	Summary
MigrationManager Test Suite `tests/Unit/Migration/MigrationManagerTest.php`	Comprehensive unit tests covering constructor validation, migration file generation, and application (upgrade/downgrade) with assertion of proper ordering, table recording, error handling for missing directories, unsupported actions/drivers, and invalid migration classes.
MigrationTable Test Suite `tests/Unit/Migration/MigrationTableTest.php`	Unit tests validating schema operations: `up()` method creates table with id (INT 11 auto-increment), migration (VARCHAR 255), and applied_at (TIMESTAMP with CURRENT_TIMESTAMP default); `down()` method drops the migration table.
MigrationTemplate Test Suite `tests/Unit/Migration/Templates/MigrationTemplateTest.php`	Unit tests verifying template generation for four migration operations (create, alter, rename, drop), confirming generated strings contain correct class declarations extending `QtMigration` and expected `$tableFactory` method invocations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

testing

Poem

🐰 Migrations tested, line by line,
Coverage climbs to ninety-nine!
Schema shifts and templates bright,
Each test case burns the darkness light. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references issue `#482` and clearly describes the main change: expanding unit test coverage for the migration package.
Linked Issues check	✅ Passed	The PR adds comprehensive unit tests for MigrationManager, MigrationTable, and MigrationTemplate classes covering success/failure paths and exception scenarios as required.
Out of Scope Changes check	✅ Passed	All changes are unit tests for the Migration package components, directly aligned with the goal of expanding coverage as specified in issue `#482`.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 0/1 reviews remaining, refill in 7 minutes and 33 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 446c447685

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/Unit/Migration/MigrationManagerTest.php`:
- Around line 30-37: Replace usage of the real migrations folder by creating a
unique per-test temporary migrations directory in the test setup: set
$this->migrationDir to a temp path (e.g.
sys_get_temp_dir().DS.'migrations_'.uniqid()) instead of base_dir(), ensure any
needed fixture migration files are copied into that temp dir so tests only see
controlled files, and update $this->existingMigrationFiles to glob that temp
dir; in tearDown remove the temp directory recursively (do not rely on `@rmdir`)
and restore or clean any state so tests are isolated; update references in
MigrationManagerTest to use $this->migrationDir and ensure cleanup handles
non-empty dirs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 14783bbb-307d-486f-9137-11cb615878e5

📥 Commits

Reviewing files that changed from the base of the PR and between fc78cf1 and 446c447.

📒 Files selected for processing (3)

tests/Unit/Migration/MigrationManagerTest.php
tests/Unit/Migration/MigrationTableTest.php
tests/Unit/Migration/Templates/MigrationTemplateTest.php

This reverts commit 446c447.

codecov · 2026-04-30T16:35:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.10%. Comparing base (fc78cf1) to head (43d3c6b).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #487      +/-   ##
============================================
+ Coverage     87.83%   89.10%   +1.26%     
  Complexity     2904     2904              
============================================
  Files           249      249              
  Lines          7653     7653              
============================================
+ Hits           6722     6819      +97     
+ Misses          931      834      -97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…on tests

[quantum-php#482] Expand migration package unit test coverage

446c447

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread tests/Unit/Migration/MigrationManagerTest.php

coderabbitai Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread tests/Unit/Migration/MigrationManagerTest.php

Revert "[quantum-php#482] Expand migration package unit test coverage"

bfc8bb7

This reverts commit 446c447.

armanist added 5 commits April 30, 2026 20:36

[quantum-php#482] Add migration template unit tests

aca382a

[quantum-php#482] Add migration table unit tests

be5fc83

[quantum-php#482] Add migration manager core validation tests

14034ba

[quantum-php#482] Add migration manager upgrade and downgrade executi…

9fdcdef

…on tests

[quantum-php#482] Add migration manager failure path coverage tests

43d3c6b

armanist added the testing label Apr 30, 2026

armanist added this to the 3.0.0 milestone Apr 30, 2026

armanist merged commit 0bf88cc into quantum-php:master Apr 30, 2026
7 checks passed

armanist deleted the feature/482-migration-coverage branch May 1, 2026 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[#482] Expand migration package unit test coverage#487

[#482] Expand migration package unit test coverage#487
armanist merged 7 commits into
quantum-php:masterfrom
armanist:feature/482-migration-coverage

armanist commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

armanist commented Apr 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

armanist commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

codecov Bot commented Apr 30, 2026 •

edited

Loading