add cmake build support - #23
Closed
madmongo1 wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
removed all the clion project files |
quicknir
reviewed
May 1, 2019
| @@ -0,0 +1,30 @@ | |||
|
|
|||
Owner
There was a problem hiding this comment.
Pretty strange that this is here, is this an accident?
Contributor
Author
There was a problem hiding this comment.
probably my IDE doing some whitespace shenanigans.
Owner
There was a problem hiding this comment.
No, I mean the whole license. The code already has a license, there isn't really a need to have another, nor lists of authors, nor companies.
Owner
|
@madmongo1 can you clarify for me, which version of cmake are you targeting? Sorry for the delay reviewing, I'll keep it speedy from here out. |
Contributor
Author
|
Hi there,
I use very recent cmake (3.13 or 3.14). I can't imagine why anyone would
use an older one.
…On Wed, 1 May 2019 at 05:15, Nir Friedman ***@***.***> wrote:
@madmongo1 <https://github.com/madmongo1> can you clarify for me, which
version of cmake are you targeting?
Sorry for the delay reviewing, I'll keep it speedy from here out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHOZSNSHAAUZ65M6BDKXNDPTEDNDANCNFSM4HG2PU5Q>
.
--
Richard Hodges
hodges.r@gmail.com
office: +442032898513
home: +376841522
mobile: +376380212
|
Contributor
Author
|
That part of the code was taken from Ruslo's example which contains his
copyright. I did the work while being paid by Quoine corp, so feel
obligated to put their name on it.
What you do is up to you.
…On Wed, 1 May 2019 at 16:25, Nir Friedman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmake/Config.cmake.in
<#23 (comment)>:
> @@ -0,0 +1,30 @@
+
No, I mean the whole license. The code already has a license, there isn't
really a need to have another, nor lists of authors, nor companies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABHOZSKGCDBDUEKKZDLS2G3PTGR6BANCNFSM4HG2PU5Q>
.
--
Richard Hodges
hodges.r@gmail.com
office: +442032898513
home: +376841522
mobile: +376380212
|
Owner
|
@madmongo1 can you clarify; you are ok with me taking the PR without the license/authorship list, or not? It wasn't clear to me from your comment. |
Contributor
Author
|
I think in this case the code is trivial enough that it can be removed.
Please go ahead and remove the license and authorship
…On Thu, 2 May 2019 at 00:05, Nir Friedman ***@***.***> wrote:
@madmongo1 <https://github.com/madmongo1> can you clarify; you are ok
with me taking the PR without the license/authorship list, or not? It
wasn't clear to me from your comment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHOZSPJJF3ZBJMJMQLVTVTPTIH4HANCNFSM4HG2PU5Q>
.
--
Richard Hodges
hodges.r@gmail.com
office: +442032898513
home: +376841522
mobile: +376380212
|
Owner
|
Closed in favor of #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I am finding wise_enum very useful but we have standardised on cmake and hunter as a build system and dependency manager.
In order to make that seamless, it's helpful to build a standard cmake script which supports installing the product and the config files.
This PR addresses only this. No code as been changed.