Skip to content

Rename HTTP Feature Policy to Permissions Policy - #40620

Merged
fxn merged 1 commit into
rails:masterfrom
Bahanix:permissions-policy
Nov 18, 2020
Merged

Rename HTTP Feature Policy to Permissions Policy#40620
fxn merged 1 commit into
rails:masterfrom
Bahanix:permissions-policy

Conversation

@Bahanix

@Bahanix Bahanix commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

HTTP Feature-Policy has been renamed to Permissions-Policy:

According to archive.org, Mozilla documentation has been updated July 14th, 2020:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy

This PR ports this renaming into Rails.

cc. @jacobbednarz who authored the feature.

@DNNX DNNX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by typo fixes.

Comment thread actionpack/lib/action_controller/metal/permissions_policy.rb Outdated
Comment thread actionpack/lib/action_dispatch/http/permissions_policy.rb Outdated
@fxn
fxn merged commit 26fd55e into rails:master Nov 18, 2020
@fxn

fxn commented Nov 18, 2020

Copy link
Copy Markdown
Member

Thanks! ❤️

@p8

p8 commented Nov 19, 2020

Copy link
Copy Markdown
Member

@Bahanix The permissions-policy also changed the format of the data to a structured header:
w3c/webappsec-permissions-policy#383

So the following:

 "usb 'self'; autoplay https://example.com; payment https://secure.example.com" 

Would need to change to

   "usb=(self), autoplay=(https://example.com), payment=(https://secure.example.com)" 

@Bahanix
Bahanix deleted the permissions-policy branch November 19, 2020 14:48
@p8

p8 commented Nov 19, 2020

Copy link
Copy Markdown
Member

I've created a PR to use the old name for the header for now. #40652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants