Bug 1999999 - Implement per-tab MediaControlKeyManager - #1

widget/gtk/MPRISServiceHandler.cpp:281

• The OnNameAcquired method assigns the GDBusConnection pointer without incrementing its reference count. This is inconsistent with the SetConnection method which properly manages reference counting. Either use SetConnection here or add g_object_ref to maintain consistent ownership semantics.

void MPRISServiceHandler::OnNameAcquired(GDBusConnection* aConnection,
                                         const gchar* aName) {
  LOGMPRIS("OnNameAcquired: %s", aName);
  mConnection = aConnection;
}

widget/gtk/MPRISServiceHandler.cpp:1

• The function name should be std::fmin for C++, but the correct function for double types is std::min in C++. std::fmin is the C math library function. Use std::min from instead for better C++ compatibility and type safety.

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-

widget/gtk/MPRISServiceHandler.cpp:1

• The function name should be std::fmin for C++, but the correct function for double types is std::min in C++. std::fmin is the C math library function. Use std::min from instead for better C++ compatibility and type safety.

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-

widget/gtk/MPRISServiceHandler.cpp:280

• The OnNameAcquired method assigns aConnection to mConnection without incrementing its reference count. This is inconsistent with SetConnection which properly manages reference counting with g_object_ref. Since OnNameAcquired is called by GLib's bus ownership mechanism and the connection lifetime is managed externally, this could lead to use-after-free issues. Consider using SetConnection(aConnection) instead of direct assignment, or add g_object_ref(aConnection) before the assignment.

  mConnection = aConnection;