Skip to content

Revert "Smart semicolon autocorrect"#3227

Merged
rgrunber merged 1 commit into
masterfrom
revert-3159-issue-703
Jul 27, 2023
Merged

Revert "Smart semicolon autocorrect"#3227
rgrunber merged 1 commit into
masterfrom
revert-3159-issue-703

Conversation

@testforstephen

Copy link
Copy Markdown
Collaborator

Reverts #3159

See #3226 for more details, this breaks the rename refactoring feature. In renaming dialog, click backspace will delete the underlying document directly.

@testforstephen testforstephen requested review from rgrunber and snjeza and removed request for snjeza July 27, 2023 11:20
@snjeza

snjeza commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

@testforstephen I will try to fix #3226

@testforstephen

Copy link
Copy Markdown
Collaborator Author

To unblock the release, I suggest we revert it first. You can fix it after 1.21.0 is released.

@rgrunber

Copy link
Copy Markdown
Member

Looks fine, but might as well updated the CHANGELOG also. Let me just do that.

@rgrunber rgrunber force-pushed the revert-3159-issue-703 branch from 77954d4 to 3c3a8f3 Compare July 27, 2023 12:34
@rgrunber rgrunber merged commit 829e8c6 into master Jul 27, 2023
@rgrunber rgrunber deleted the revert-3159-issue-703 branch July 27, 2023 12:41
@rgrunber rgrunber added this to the End July 2023 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants