PaliGemma2 model upload support - #347
Merged
Merged
Conversation
lrosemberg
marked this pull request as draft
December 10, 2024 23:19
lrosemberg
commented
Dec 12, 2024
| + format | ||
| + ": %d%% [%d / %d] bytes" % (current / total * 100, current, total) | ||
| f"{location} to " | ||
| f"{format}: " |
Contributor
Author
There was a problem hiding this comment.
ruff flagged this
lrosemberg
commented
Dec 12, 2024
| datetime.fromisoformat(ts) | ||
| return True | ||
| except: | ||
| except: # noqa: E722 |
Contributor
Author
There was a problem hiding this comment.
ruff flagged this
Contributor
There was a problem hiding this comment.
We should capture only expected exceptions.
With this bare except, you can even add syntax errors for the try block.
Suggested change
| except: # noqa: E722 | |
| except (ValueError, TypeError): |
lrosemberg
requested review from
balthazur,
iurisilvio,
probicheaux and
tonylampada
December 13, 2024 02:59
lrosemberg
marked this pull request as ready for review
December 13, 2024 03:01
iurisilvio
previously approved these changes
Dec 13, 2024
Comment on lines
+826
to
+827
| f"{location} to " | ||
| f"{format}: " |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| f"{location} to " | |
| f"{format}: " | |
| f"{location} to {format}: " |
| datetime.fromisoformat(ts) | ||
| return True | ||
| except: | ||
| except: # noqa: E722 |
Contributor
There was a problem hiding this comment.
We should capture only expected exceptions.
With this bare except, you can even add syntax errors for the try block.
Suggested change
| except: # noqa: E722 | |
| except (ValueError, TypeError): |
iurisilvio
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PaliGemma2 model upload support
upload_modelcommand with the following model types:paligemma2-3b-pt-224paligemma2-3b-pt-448paligemma2-3b-pt-896Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?