update to 0.6.0#181
Merged
Merged
Conversation
Closed
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 69.19% 69.06% -0.14%
==========================================
Files 15 15
Lines 2227 2227
==========================================
- Hits 1541 1538 -3
- Misses 686 689 +3 |
mroethke
requested changes
Oct 5, 2018
| * Version 0.6.0 | ||
| - Change default symbol visibility: Hide all symbols per default, | ||
| export public symbols explicitly | ||
| - Change API for interval mode {set,get}_interval_mod and enumerations |
Member
There was a problem hiding this comment.
IIRC the interval mode api is not officially released yet, therefore we should note it's addition not that it was changed within the dev cycle.
Member
Author
|
@mroethke your comment is addressed. |
mroethke
approved these changes
Oct 5, 2018
mroethke
requested changes
Oct 5, 2018
mroethke
left a comment
Member
There was a problem hiding this comment.
I believe I just found a bug in the cmake install target, I'm investigating that right now and will report back shortly.
This it not related to this pr but should be resolved before releasing 0.6.0, so I'm blocking this PR again.
Member
Author
mroethke
approved these changes
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.