merge master#1
Open
se77enn wants to merge 777 commits into
Open
Conversation
* Add rail fence cipher encoder & decoder * Add functions to encode & decode strings using the rail fence cipher method * Add unit tests covering empty strings, pair & odd number of characters in the input string, n=3 & n=4 * Add a README.md for the algorithm * Update root README.md to link to the new algorithm * Rename the CI workflow file. Co-authored-by: Oleksii Trekhleb <trehleb@gmail.com>
* Add word to avoid misinterpretation * Rename the CI workflow file. Co-authored-by: Sagid Magomedov <sagid-m@yandex-team.ru> Co-authored-by: Oleksii Trekhleb <trehleb@gmail.com>
* Linked List Spanish Traslation * Rename the CI workflow file. Co-authored-by: Oleksii Trekhleb <trehleb@gmail.com>
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v8.0.0...v8.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add divide and conquer example: best time to buy and sell stocks. * Add divide and conquer example: best time to buy and sell stocks. * Add dynamic programming version.
* Add ukrainian translate. * Error correction. * Add a link to UA version to all README.file.
* add the DS link * Finish translating math * add Arabic version of the README FILE * add Arabic version of the README FILE * add the arabic readme file link to main readme file * add the arabic readme file link to main readme file * add the arabic readme file link to main readme file Co-authored-by: Oleksii Trekhleb <trehleb@gmail.com>
The existing insertion sort implementation began by iterating from 0 until the end of the array, but it is only necessary to iterate from 1 until the end of the array, since at the 0th index, there is nothing to compare to the left of the element. In order to complete this change, I also had to update the tests to reflect the fact that the algorithm visits each index 1 less time. Finally, I corrected the grammar/wording of the comments. Co-authored-by: Oleksii Trekhleb <trehleb@gmail.com>
The JSDoc comment states the valid position range is '1 to 75', but the code validates against topMaxValidPosition = 70. This PR fixes the documentation to match the implementation.
String.prototype.substr() is deprecated and may be removed in future JavaScript engine versions (Annex B of the ECMAScript specification). Replaced all occurrences in the codebase with String.prototype.substring(): - src/algorithms/string/rabin-karp/rabinKarp.js - src/algorithms/cryptography/polynomial-hash/__test__/SimplePolynomialHash.test.js - src/algorithms/cryptography/polynomial-hash/__test__/PolynomialHash.test.js The behavior is identical since all substr(start, length) calls are converted to substring(start, start + length) with the same arguments. All existing tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.