Skip to content

Add optional preheader and AMP fields#80

Merged
turnerdev merged 5 commits into
masterfrom
add-preheader-and-amp-fields
Jul 14, 2022
Merged

Add optional preheader and AMP fields#80
turnerdev merged 5 commits into
masterfrom
add-preheader-and-amp-fields

Conversation

@turnerdev

Copy link
Copy Markdown
Contributor

Add support for preheader and amp_html optional fields for template operations

Description

  • Add preheader and amp_html to create_template, create_new_locale, create_new_version and update_template_version
  • Fixed some tests cases, removed hardcoded resource IDs

Motivation and Context

Parity with the current Sendwithus API

How Has This Been Tested?

  • All new and currently passing tests pass.
  • Created a test consumer to verify all affected operations work as expected against test and production environments.
  • amp_html not yet GA, omitted from test cases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@turnerdev turnerdev requested a review from a team as a code owner July 7, 2022 18:53
@turnerdev turnerdev merged commit d80db6a into master Jul 14, 2022
@turnerdev turnerdev deleted the add-preheader-and-amp-fields branch July 14, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants