test: add coverage for mkdir -p on existing directories#1256
Open
MD-Mushfiqur123 wants to merge 1 commit into
Open
test: add coverage for mkdir -p on existing directories#1256MD-Mushfiqur123 wants to merge 1 commit into
MD-Mushfiqur123 wants to merge 1 commit into
Conversation
nfischer
approved these changes
Jun 6, 2026
nfischer
left a comment
Member
There was a problem hiding this comment.
Thank you! Two optional suggestions, but this looks good
| }); | ||
|
|
||
| test('-p flag: existing directory', t => { | ||
| shell.mkdir('-p', `${t.context.tmp}/existing`); |
Member
There was a problem hiding this comment.
Remove the '-p' from this call, to make it clearer that this is part of the setup and not the real test (which is the next call to shell.mkdir('-p', ...)).
| }); | ||
|
|
||
| test('-p flag: create new subdirectory within existing tree', t => { | ||
| shell.mkdir('-p', `${t.context.tmp}/grandparent/parent`); |
Member
There was a problem hiding this comment.
suggestion: let's remove parent from this call (but leave it in the next call).
Then in the portion of the test below, let's have calls to fs.existsSync() for both '.../parent' and '.../parent/child' to verify both directories are created. This will give us test coverage that mkdir('-p') can create multiple directories in the hierarchy while also testing that we can work within an existing directory tree.
Signed-off-by: MD-Mushfiqur123 <md.mushfiqur.rahim123@gmail.com>
dc6bf06 to
0b6dfe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases for on directories that already exist:
Fixes #1022