fix: use require.resolve() for exec-child.js path to fix Next.js/webp…#1259
Merged
Conversation
…ack bundler compatibility (shelljs#1158) When Next.js (or any webpack-based bundler) bundles the server-side code, __dirname is replaced with the bundled output directory (e.g. .next/server/vendor-chunks/). This causes child_process.execFileSync to look for exec-child.js in the wrong location, leading to the 'Cannot find module' error. Fix: resolve exec-child.js path using require.resolve() at module load time. require.resolve() always returns the real filesystem path of the module, unaffected by bundler __dirname transformations.
nfischer
approved these changes
Jun 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 97.09% 97.10%
=======================================
Files 36 36
Lines 1517 1518 +1
=======================================
+ Hits 1473 1474 +1
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ack bundler compatibility (#1158)
When Next.js (or any webpack-based bundler) bundles the server-side code, __dirname is replaced with the bundled output directory (e.g. .next/server/vendor-chunks/). This causes child_process.execFileSync to look for exec-child.js in the wrong location, leading to the 'Cannot find module' error.
Fix: resolve exec-child.js path using require.resolve() at module load time. require.resolve() always returns the real filesystem path of the module, unaffected by bundler __dirname transformations.