This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Commands#49
Merged
Merged
Conversation
garyb
approved these changes
Oct 28, 2017
garyb
left a comment
Member
There was a problem hiding this comment.
I'd say this is a breaking change, as the type signature of existing functions has been changed (like the need to change to set' illustrates).
It's true that the DSL interface may not have changed breakingly, but if any part of the interface of a library does it's considered breaking. :)
| try { | ||
| chart.setOption(option, false, false); | ||
| } catch (e) { | ||
| connsole.error(e); |
Member
There was a problem hiding this comment.
Also, is this a good idea anyway? What's the thinking by making it a silent error?
Member
Author
There was a problem hiding this comment.
Well, that's provide at least a message, because halogen for example eats all exceptions and silently breaks
| series a = set "series" =<< buildSeries a | ||
| series ∷ ∀ i m. Monad m ⇒ CommandsT TP.SeriesI m ~> CommandsT (series ∷ I|i) m | ||
| series a = do | ||
| set "series" =<< buildSeries a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things were added
try/catchto set and reset foreign implementations@garyb would you mind to take a quick look? I'm not sure if this change is major or patch real breaks may occur only in situation like in
Linemodule when usermapsDSL.