Update: Pixman to 0.46.4 and Cairo to to 1.18.4 - #1624
Merged
Conversation
Member
|
Awesome. I'm in favor of having updated dependencies too. The CMake documentation says for version >=4 that the cmake_minimum_required version needs to be 3.5 or higher. How does this work with 3.25? |
Member
Author
|
I do not know how but it does - our main CMake file is the same way since a208201 Edit: Ah, CMake versioning is "the other way :-)" - in other words 25 > 5 |
Member
Author
|
For cross reference - the last time @whitequark updated it: https://lists.freedesktop.org/archives/pixman/2016-May/thread.html#4615 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I already updated our respective vendored repositories here:
https://github.com/solvespace/pixman/tree/0.46.4%2Bcmake
and here:
https://github.com/solvespace/cairo/tree/1.18.4%2Bcmake
Seems to work fine on Windows.
Fixes the macOS CI failure because of CMake>=4 :
https://github.com/solvespace/solvespace/actions/runs/17682347253
We could be more conservative and only update the
cmake_minimum_required(VERSION 3.18...3.25)line, but we have not updated these two in ten years so I think it is better to update them.