ci: fix the macOS CI build - #1629
Conversation
The build was failing due to the removal of the Hombrew Ventura bottle for OpenMP, because Ventura is EOL since the release of macOS Tahoe. The oldest supported macOS version is currently Sonoma. However, it'll be EOL in a year, so for arm64 use Sequoia instead, as most users are likely on it or Tahoe anyway (can't use Sequoia for x86_64, because the only supported version for x86_64 is Sonoma, so we'll likely need to get rid of the x86_64 build in a year, or build without OpenMP support). While at it, remove the patch for libpng, which doesn't apply and isn't needed after the last update of the dependency.
|
Thanks @iscgar. Merged. Interesting whether Sequoia is really not supported on x64 Wikipedia thinks it is and so does Apple . Or do you mean Homebrew? It is harder to figure out what it supports on x64 but it looks to me that 14/Sonoma or higher are supported. |
|
FWIW my ancient Mojave 10.14.6 in a virtual machine offers me to update to Sequoia when I check for updates. |
|
I meant that the OpenMP bottle is only available for Sonoma on x86_64, though I just tried and seems to automatically use the Sonoma bottle even when specifiying a Sequoia bottle tag, so I'm not sure why it didn't work when I tried it before. For the sake of consistency, I'll submit a PR to fix this. |
|
Aha! Understood. Don't bother with a PR I'll just fix it in the lazy way (in the GitHub editor :-) |
|
Missed your comment and already opened #1630. Feel free to close it. |
|
Merged :-) |
The build is currently failing due to the removal of the Hombrew Ventura bottle for OpenMP, because Ventura is EOL since the release of macOS Tahoe.
The oldest supported macOS version is currently Sonoma. However, it'll be EOL in a year, so for arm64 use Sequoia instead, as most users are likely on it or Tahoe anyway (can't use Sequoia for x86_64, because the only supported version for x86_64 is Sonoma, so we'll likely need to get rid of the x86_64 build in a year, or build without OpenMP support).
While at it, remove the patch for libpng, which doesn't apply and isn't needed after the last update of the dependency.