Skip to content

Name fix - #1635

Merged
phkahler merged 2 commits into
solvespace:masterfrom
rpavlik:name-fix
Nov 12, 2025
Merged

Name fix#1635
phkahler merged 2 commits into
solvespace:masterfrom
rpavlik:name-fix

Conversation

@rpavlik

@rpavlik rpavlik commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

Looks like I failed to mailmap and stuff here, oops!

Would be good to make sure the metadata file is updated before the next release so we don't have to patch it in flathub too.

@ruevs

ruevs commented Nov 10, 2025

Copy link
Copy Markdown
Member

This is the first time I've heard about this git feature. Interesting.

https://git-scm.com/docs/gitmailmap

Is it necessary?

@rpavlik

rpavlik commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Well I changed my name and email, among other things 😉 , so yeah, it's the only way to avoid deadnaming me in the history, feels pretty necessary to me. While I was at it, I did look at the results of git shortlog -s -e to merge duplicate contributor entries for other contributors too, into their most recently used ID. (Have done this same process for every project I touch...) But I guess it's ultimately the community's choice, I don't want to rock the boat by hitting merge on my own PR.

@ruevs

ruevs commented Nov 12, 2025

Copy link
Copy Markdown
Member

@rpavlik thanks for the explanation. It makes sense and I'm perfectly fine with this. @phkahler?

@phkahler
phkahler merged commit 2e0c947 into solvespace:master Nov 12, 2025
4 checks passed
@rpavlik
rpavlik deleted the name-fix branch November 17, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants